Added phone field to model for talk proposal (CFP page) #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PirosB3
reviewed
Mar 6, 2018
.gitignore
Outdated
| @@ -25,6 +25,7 @@ var/ | |||
| *.egg | |||
| symposion | |||
| pyenv | |||
| pybay/proposals/migrations | |||
There was a problem hiding this comment.
Why are you avoiding migrations directory here? Don't we need these?
There was a problem hiding this comment.
I assumed everyone would run their own migrations, and that my migrations shouldn't be committed into your migrations.
If I've got this wrong, let me know and I'll back it out! I'm used to manually writing the upgrade scripts.
There was a problem hiding this comment.
In fact, tests cannot run because they cannot apply such migration:
django.db.utils.OperationalError: no such column: proposals_talkproposal.phone
Can you please include your migration file?
…into phone-field-to-model
|
Thanks Linda! migrations files are used by test runner to setup + teardown tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BethanyG and I worked on this PR together. :)
Make sure to
makemigrationsandmigrate.