Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speakers list page #74

Merged
merged 3 commits into from
May 24, 2017
Merged

Speakers list page #74

merged 3 commits into from
May 24, 2017

Conversation

filipeximenes
Copy link

PirosB3
PirosB3 reviewed May 23, 2017
View reviewed changes
pybay/views.py
result__status='accepted')
speakers = []
for proposal in accepted_proposals:
speakers += list(proposal.speakers())
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can lead to duplicate speakers

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry! didn't see above :)

@PirosB3
Copy link

PirosB3 commented May 23, 2017

brilliant! I will test today and merge

@sfpython
Copy link

Excellent! Thank you so much @filipeximenes. @PirosB3, I'll let you do the merging.

@PirosB3 PirosB3 changed the base branch from master to filipeximenes_speakers May 24, 2017 02:48
@PirosB3 PirosB3 merged commit b3a67b5 into pybay:filipeximenes_speakers May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PirosB3 PirosB3 PirosB3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filipeximenes @PirosB3 @sfpython