-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow FAQs to be shown on home/sponsor/registration pages #80
Conversation
57611e7
to
18ff11a
Compare
pybay/urls.py
Outdated
from pybay.views import ( | ||
pybay_cfp_create, pybay_sponsors_list, | ||
pybay_faq_index, pybay_speakers_list) | ||
from pybay import views |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems more a matter of taste than what the PR is asking for and adds an extra namespace that is not needed. Lets not mix the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Except for the comment, this looks like a fantastic job Yann! The PR is in staging now for UX review. |
urlpatterns = [ | ||
url(r"^$", TemplateView.as_view(template_name="frontend/index.html"), name="home"), | ||
url(r"^$", faq_view(template_name="frontend/index.html", faq_filter="show_on_home"), name="home"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you calling this faq_view
? isn't it home page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses data from the FAQs. If the name is too confusing I could change it to something else
@mzdaniel merged when you are happy with this |
Yann, this is great stuff. I anticipate this feature will save me and other devs over 20 hours a week getting content on the website and editing. Minor changes:
|
I am merging this code now. Great work Yann! |
https://trello.com/c/LMRXedBp/133-implement-sections-of-faq-on-sponsors-and-registration-page