-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing signature #2363
Conversation
I was about to say "Isn't that because it's a constructor from Maybe do the same for the |
Someone told me when I found this a while back it was probably just an oversight, but I don't know where that conversation was. |
f3cc16d
to
dd9f742
Compare
By the way, buffer info is information about the data, but it does not contain ownership information. The handle contains ownership information, so you can be sure the owning object is not destroyed while the array is still present. The other constructors support this, it's just missing from the direct buffer info constructor. |
Alright; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I spent a few minutes looking in the nump.h sources, this change seems super safe to me.
All the other array constructors have an optional handle, but this one was missing.