-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enum: Add Enum.value property #2739
enum: Add Enum.value property #2739
Conversation
e5010de
to
f3f32b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine in general. However, shouldn't we be looking at python3.4 enums, as in #2704 ? Yes, "what about python2" is a good argument, but even pip
is dropping support for python2 in January.
EDIT: Moved here: #2332 (comment) |
Er, also - I shoulda put that design comment in the issue. EDIT: Done. |
@bstaletic Any chance you got a brief few min to approve the latest changes here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. This looks perfectly fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks, @EricCousineau-TRI!
Are you also planning to tackle the __iter__
part of #2332?
Let's see if this still makes it into 2.6.2? I guess it could conflict with users' code when they already defined |
Hopefully it's sufficiently benign! It does modify the class defined by My vote is, onwards! It cool if I merge?! 😬 |
As far as I'm concerned, yes :-) Should we quickly check with @henryiii on the 2.6.2 thing; he's been unofficially managing the last few releases? |
Sounds good! Henry, you cool with pushing the merge button on this one? |
I've edited the changelog a bit to make it sound a bit more like a patch-worthy addition. ;) |
Thanks for picking this up, @EricCousineau-TRI! |
Sweet, thank y'all for reviewing 'n merging! |
Description
Towards #2332 - adds a
.value
attributeSuggested changelog entry: