Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: STATIC and SHARED flags not being detected #2796

Merged
merged 2 commits into from
Jan 14, 2021
Merged

fix: STATIC and SHARED flags not being detected #2796

merged 2 commits into from
Jan 14, 2021

Conversation

heyer2
Copy link
Contributor

@heyer2 heyer2 commented Jan 14, 2021 •
edited by henryiii
Loading

I noticed SHARED and STATIC flags no longer being respected after updating pybind11. This fixes it.

Suggested changelog entry:

* Fix ``STATIC`` / ``SHARED`` being ignored in FindPython mode.

@henryiii henryiii added this to the v2.6.2 milestone Jan 14, 2021
@henryiii henryiii changed the title Fix STATIC and SHARED flags not being detected fix: STATIC and SHARED flags not being detected Jan 14, 2021
@henryiii
Copy link
Collaborator

This only fixes the new FindPython, assuming there is nothing wrong with the classic version?

@heyer2
Copy link
Contributor Author

heyer2 commented Jan 14, 2021

Classic one seems fine to me.

@YannickJadoul
Copy link
Collaborator

Thanks, @heyer2!

@YannickJadoul YannickJadoul merged commit 76a1600 into pybind:master Jan 14, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jan 14, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jan 25, 2021
@henryiii henryiii mentioned this pull request Jan 26, 2021
Merged
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannickJadoul YannickJadoul YannickJadoul approved these changes

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@heyer2 @henryiii @YannickJadoul