Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding codespell to .pre-commit-config.yaml #3076

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Adding codespell to .pre-commit-config.yaml #3076

merged 1 commit into from
Jul 6, 2021

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jul 6, 2021

Description

Follow-on to PR #3075.

Suggested changelog entry:

Checks for common misspellings were added to the pre-commit hooks.

@rwgk rwgk requested a review from henryiii as a code owner July 6, 2021 18:09
@rwgk rwgk mentioned this pull request Jul 6, 2021
Merged
@rwgk
Copy link
Collaborator Author

rwgk commented Jul 6, 2021

CI finished without issues. @henryiii if this looks good to you, do you want to merge?

@rwgk
Copy link
Collaborator Author

rwgk commented Jul 6, 2021

Thanks @henryiii!

@rwgk rwgk merged commit 0ad116d into pybind:master Jul 6, 2021
@rwgk rwgk deleted the pre-commit_codespell branch July 6, 2021 21:10
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jul 6, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 13, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rwgk @henryiii