Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clone of @virtuald's PR #2112 with minor enhancements. #3215

Merged
merged 3 commits into from
Aug 24, 2021
Merged

Clone of @virtuald's PR #2112 with minor enhancements. #3215

merged 3 commits into from
Aug 24, 2021

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Aug 24, 2021

Description

See description of PR #2112. This PR only adds:

  • A source code comment pointing to the exact base version of _PyErr_FormatVFromCause.
  • Adds back asserts removed by @virtuald.

Suggested changelog entry:

* Added ``py::raise_from`` to enable chaining exceptions

@rwgk rwgk mentioned this pull request Aug 24, 2021
Closed
3 tasks
@rwgk
Copy link
Collaborator Author

rwgk commented Aug 24, 2021

CI is green!
@henryiii, @Skylion007, I'll merge this helper PR now, based on your approvals under #2112. Thanks @virtuald!

@rwgk rwgk merged commit c8ce4b8 into pybind:master Aug 24, 2021
@rwgk rwgk deleted the pr2112_with_exact_base_version branch August 24, 2021 00:30
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 24, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Sep 16, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwgk @henryiii @virtuald