tests: allow Eigen repo and version to be overridden #3324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
force-pushed
the
bugfix_std_free_eigen_off
branch
from
daa6f41 to
f32ffec
Compare
rwgk
changed the title
-DDOWNLOAD_EIGEN=OFF-DDOWNLOAD_EIGEN=OFF (temporarily).
|
It's very easy to roll back. Better than driving blind while the eigen problem is being worked on. |
henryiii
force-pushed
the
bugfix_std_free_eigen_off
branch
from
f32ffec to
489b81d
Compare
henryiii
changed the title
-DDOWNLOAD_EIGEN=OFF (temporarily).
|
Will need a rebase and merge, since we want to roll back the second commit after they have the original repo restored. |
henryiii
reviewed
Oct 4, 2021
| set(PYBIND11_EIGEN_REPO | ||
| "https://gitlab.com/libeigen/eigen.git" | ||
| CACHE STRING "Eigen repository to use for tests") | ||
| # This hash is for 3.3.8, using a hash for security reasons |
There was a problem hiding this comment.
Technically, this is also faster on re-configure, too, since it doesn't have to reach out again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To work around gitlab eigen outage.
The eigen repo is still unavailable (seems to be 2+ days now):