feat: Add C++ binding to throw AttributeError #3387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #687 . Adds a C++ binding to throw and catch AttributeError, useful for defining custom
__setattr__
. The other exception I was eyeing adding was NameError, but it is rare for any user to want to manually throw them, unlike with an AttributeError. Then again, we already expose bindings for ImportError, so I would advocating for eventually adding NameError was well at some point.This does not significantly extend the API surface considering it supports the exceptions of other types. This doesn't implement any exception translation from C++ errors so it should be a very backwards compatible and lightweight change.
Suggested changelog entry: