Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing currently broken ICC Latest C++17 with C++14. #3551

Merged
merged 6 commits into from
Dec 21, 2021

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Dec 13, 2021

Description

This restores fully functional CI against master.

The C++17 build was working with

  • Intel 2021.4.0.20210910 (/opt/intel/oneapi/compiler/2021.4.0/linux/bin/intel64/icpc)

but started failing with

  • Intel 2021.5.0.20211109 (/opt/intel/oneapi/compiler/2022.0.0/linux/bin/intel64/icpc)

Related PRs for reporting errors to Intel:

Suggested changelog entry:

@rwgk rwgk closed this Dec 13, 2021
@rwgk rwgk reopened this Dec 13, 2021
@rwgk rwgk changed the title Trivial change. Replacing currently broken ICC Latest C++17 with C++14. Dec 16, 2021
@rwgk rwgk requested a review from henryiii December 16, 2021 04:17
@henryiii
Copy link
Collaborator

Looks like this is broken again. I'd be fine to roll this back to C++14 for now until Intel gets this fixed. Has it been reported to Intel?

@rwgk rwgk closed this Dec 20, 2021
@rwgk
Copy link
Collaborator Author

rwgk commented Dec 20, 2021

Trying again in the exact same state to see if the 3.9-dbg (deadsnakes) • Valgrind • x64 failure reproduces.

@rwgk rwgk reopened this Dec 20, 2021
@rwgk rwgk marked this pull request as ready for review December 20, 2021 19:26
@rwgk
Copy link
Collaborator Author

rwgk commented Dec 20, 2021

Hi @henryiii, I'll revive #3553 after this PR is merged, for reporting to Intel.

@henryiii
Copy link
Collaborator

Added a temporary fix for pypa/setuptools#2946.

@henryiii henryiii closed this Dec 20, 2021
@henryiii henryiii reopened this Dec 20, 2021
@henryiii henryiii merged commit b3d9c35 into pybind:master Dec 21, 2021
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Dec 21, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Dec 21, 2021
@rwgk rwgk deleted the ci_issues branch December 22, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants