fix: do not use LTS on mips64 and ppc64le #3557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwgk
reviewed
Dec 18, 2021
| _pybind11_return_if_cxx_and_linker_flags_work( | ||
| HAS_FLTO_THIN "-flto=thin${cxx_append}" "-flto=thin${linker_append}" | ||
| PYBIND11_LTO_CXX_FLAGS PYBIND11_LTO_LINKER_FLAGS) | ||
| endif() | ||
|
|
||
| if(NOT HAS_FLTO_THIN) | ||
| if(NOT HAS_FLTO_THIN AND NOT NO_FLTO_ARCH) |
There was a problem hiding this comment.
AND NOT NO...
Could IS_FLTO_ARCH work out more nicely here?
There was a problem hiding this comment.
I was mostly following the original patch 😳.
There was a problem hiding this comment.
Ah, the reasoning was that this forces NO_FLTO, while IS_FLTO would not be accurate, it still might not be.
henryiii
force-pushed
the
henryiii/fix/flto_arch
branch
from
f6783a1
to
02d6d45
Compare
rwgk
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3528. Using a nicer version of the patch Debian is applying with https://salsa.debian.org/science-team/pybind11/-/blob/master/debian/patches/drop_lto_on_some_archs.patch.
Suggested changelog entry: