Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC C++20 test_eigen #3741

Merged
merged 7 commits into from
Feb 16, 2022
Merged

MSVC C++20 test_eigen #3741

merged 7 commits into from
Feb 16, 2022

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Feb 15, 2022

Description

This PR enables test_eigen for MSVC 2019 & 2022 C++20.

With the combination of

  • re-enabling the age-old MSVC workaround even for MSVC C++20 (533e5ad)
  • adding a warning suppression to eigen.h (cbb29c0)

test_eigen runs successfully with MSVC 2019 & 2022 C++20.

See also: #3722 (comment) (the entire discussion thread there)

Suggested changelog entry:

Testing eigen.h is now also enabled for MSVC 2019 & 2022 in C++20 mode.

@rwgk
Copy link
Collaborator Author

rwgk commented Feb 15, 2022

Before 533e5ad all tests passed (warnings ignored). After the commit this error is generated (copied from MSVC 2022 C++20 log):

D:\a\pybind11\pybind11\include\pybind11\cast.h(1014,1): error C2752: 'pybind11::detail::type_caster<Eigen::Ref<Eigen::Matrix<double,-1,-1,0,-1,-1>,0,Eigen::OuterStride<-1>>,void>': more than one partial specialization matches the template argument list [D:\a\pybind11\pybind11\build\tests\pybind11_tests.vcxproj]

@rwgk rwgk changed the title MSVC C++20 eigen MSVC C++20 test_eigen Feb 16, 2022
@rwgk rwgk marked this pull request as ready for review February 16, 2022 00:58
@rwgk rwgk requested a review from henryiii as a code owner February 16, 2022 00:58
@rwgk rwgk requested a review from Skylion007 February 16, 2022 00:58
@rwgk rwgk merged commit 009ffc3 into pybind:master Feb 16, 2022
@rwgk rwgk deleted the msvc2022_eigen branch February 16, 2022 15:07
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 16, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants