Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable clang-tidy check modernize-use-nullptr #3881

Merged
merged 3 commits into from
Apr 18, 2022
Merged

chore: enable clang-tidy check modernize-use-nullptr #3881

merged 3 commits into from
Apr 18, 2022

Conversation

Skylion007
Copy link
Collaborator

Description

  • I noticed we didn't have the check modernize-use-nullptr enabled. This replaces usages of the NULL macro or 0 with nullptr when appropriate. This makes the code a bit more readable, modern, and standard compliant.
  • I also sorted some checks that were out of order.

Suggested changelog entry:

* Enable modernize-use-nullptr clang-tidy checks

@Skylion007 Skylion007 requested a review from rwgk April 18, 2022 14:27
henryiii
henryiii approved these changes Apr 18, 2022
View reviewed changes
Copy link
Collaborator

@henryiii henryiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, could have sworn we had this one, it's usually one of the first ones I add.

@Skylion007 Skylion007 merged commit fbcde3f into pybind:master Apr 18, 2022
@Skylion007 Skylion007 deleted the skylion007-modernize-use-nullptr branch April 18, 2022 15:09
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Apr 18, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 7, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@rwgk rwgk Awaiting requested review from rwgk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skylion007 @henryiii