Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing undef in pytypes #4087

Merged
merged 1 commit into from
Jul 22, 2022
Merged

Fix missing undef in pytypes #4087

merged 1 commit into from
Jul 22, 2022

Conversation

Skylion007
Copy link
Collaborator

Description

@Skylion007 Skylion007 requested review from rwgk and henryiii July 21, 2022 17:39
rwgk
rwgk approved these changes Jul 21, 2022
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely a good change. Just curious: did this cause an actual problem? (Thinking: no, but maybe I'm overlooking something?)

@Skylion007
Copy link
Collaborator Author

Definitely a good change. Just curious: did this cause an actual problem? (Thinking: no, but maybe I'm overlooking something?)

Nope, didn't cause a problem. Just noticed it when looking over the code base.

@Skylion007 Skylion007 merged commit b07975f into pybind:master Jul 22, 2022
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jul 22, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Oct 20, 2022
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii Awaiting requested review from henryiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Skylion007 @rwgk @henryiii