Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: allow noexcept lambdas in C++17. Fix #4565 #4593

Merged

Conversation

Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Mar 27, 2023

Description

Allows lambda specified to function defs to be noexcept(true) in C++17. This ended up being a rather quick fix compared to more general case which would require some extensive meta-templating to do this properly in C++17.

Suggested changelog entry:

* Allow lambda specified to function definition to be noexcept(true) in C++17

@Skylion007 Skylion007 marked this pull request as ready for review March 27, 2023 17:39
@Skylion007 Skylion007 changed the title bugfix: allow noexcept lambdas in CPP17. Fix #4565 bugfix: allow noexcept lambdas in C++17. Fix #4565 Mar 27, 2023
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

tests/test_constants_and_functions.cpp Outdated Show resolved Hide resolved
@Skylion007 Skylion007 merged commit 1e8b52a into pybind:master Mar 28, 2023
@Skylion007 Skylion007 deleted the skylion007/allow-noexcept-lambdas branch March 28, 2023 00:21
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Mar 28, 2023
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants