Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmake): disable strip when build type is unset #4780

Merged
merged 1 commit into from
Aug 8, 2023
Merged

fix(cmake): disable strip when build type is unset #4780

merged 1 commit into from
Aug 8, 2023

Conversation

tttapa
Copy link
Contributor

@tttapa tttapa commented Aug 6, 2023

Description

This restores the pre-2.10.2 behavior, as discussed in #4454.

Suggested changelog entry:

* ``pybind11_strip`` is no longer automatically applied when ``CMAKE_BUILD_TYPE`` is unset.

@tttapa tttapa requested a review from henryiii as a code owner August 6, 2023 01:36
@rwgk
Copy link
Collaborator

rwgk commented Aug 8, 2023

Merging this, too, to get this into smart_holder update as well.

@rwgk rwgk merged commit 4bf60c6 into pybind:master Aug 8, 2023
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Aug 8, 2023
@henryiii henryiii changed the title Disable strip when build type is unset fix(cmake): disable strip when build type is unset Nov 15, 2023
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henryiii henryiii henryiii approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tttapa @rwgk @Skylion007 @henryiii