chore: help Coverty avoid generating a false positive. #4817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `assert()` in the only place where `curr_overl` could become `nullptr`.
rwgk
changed the title
|
Does |
Changed to The longer name is great, I don't have a strong preference one way or another. |
henryiii
approved these changes
Sep 1, 2023
|
Thanks Henry! |
henryiii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please see #4814 for background.
This PR does not change the pybind11 behavior at all when
NDEBUGis set.For Coverty use
-UNDEBUG.The variable name change was helpful in determining that we think of the Coverty result as a false positive. The name change could be reverted, but is useful to keep (increases readability).
Suggested changelog entry:
An ``assert()`` was added to help Coverty avoid generating a false positive.