chore: added check on iterator end position #5129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I can tell the test that failed has nothing to do with this PR. Can anyone take a look? |
Skylion007
reviewed
May 24, 2024
|
Wouldn't it possibly be better to turn the assert into a failure that always triggers? Letting it fall through in release mode seems unideal, even though that's what's happening now. |
Hi @henryiii , I refactored it to do what you suggested. |
rwgk
requested changes
May 27, 2024
henryiii
approved these changes
May 27, 2024
rwgk
requested changes
May 27, 2024
|
Thanks for sticking with it! |
henryiii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4822
Description
Issue #4822 reported an issue Coverity found with an unchecked iterator in release mode. gcc13 also finds this by default and reports a warning.
Suggested changelog entry: