-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Guideline for merging PRs
Henry Schreiner edited this page Jun 11, 2021
·
1 revision
To merge a PR, the procedure depends on the size of the PR.
- Large feature in branch
- PRs must have [branch name] prefix
- To-branch PRs can be merged quickly
- Merging a large branch = 3 maintainers
- Focused new feature
- 2 maintainers + 1 week from LGTM or 3 maintainers
- Work already agreed upon on the roadmap
- 1 (other) maintainer
- Maintenance
- "Code owner" approval or 1 week
Code written here is licensed under pybind11's license (BSD-3) unless otherwise stated.