Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move to rules_python and remove local_config_python #71

Closed
junyer opened this issue Feb 9, 2024 · 2 comments · Fixed by #72 or #73
Closed

move to rules_python and remove local_config_python #71

junyer opened this issue Feb 9, 2024 · 2 comments · Fixed by #72 or #73

Comments

@junyer
Copy link
Contributor

junyer commented Feb 9, 2024

Although bazelbuild/rules_python#824 isn't formally "done" yet, it seems that pybind11_bazel can move wholesale to rules_python (i.e. using @rules_python//python/cc:current_py_cc_headers and @rules_python//python/cc:current_py_cc_libs) and remove local_config_python entirely. At that point, the name "python_configure" will no longer make sense and should be replaced by, say, "pybind11_configure". Notably, only Bzlmod users need to "configure" something (just getting pybind11 itself) whereas WORKSPACE users no longer need to "configure" anything.

@junyer
Copy link
Contributor Author

junyer commented Feb 12, 2024

Thanks to @rickeylev's advice, I'm going to simplify things even further: by turning @pybind11 into a hidden implementation detail, Bzlmod users won't need to "configure" anything either! Also, the pybind11_embed target no longer makes sense and will be removed in favour of equivalent support in the next release of rules_python. All of this will be mildly disruptive, but for the best both for pybind11_bazel itself (drastically simpler implementation!) and, more importantly, for pybind11_bazel users.

@junyer
Copy link
Contributor Author

junyer commented Feb 13, 2024

Reopening since there are further PRs to come.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant