-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move to rules_python and remove local_config_python #71
Comments
Thanks to @rickeylev's advice, I'm going to simplify things even further: by turning |
Reopening since there are further PRs to come. |
Although bazelbuild/rules_python#824 isn't formally "done" yet, it seems that pybind11_bazel can move wholesale to rules_python (i.e. using
@rules_python//python/cc:current_py_cc_headers
and@rules_python//python/cc:current_py_cc_libs
) and remove local_config_python entirely. At that point, the name "python_configure" will no longer make sense and should be replaced by, say, "pybind11_configure". Notably, only Bzlmod users need to "configure" something (just getting pybind11 itself) whereasWORKSPACE
users no longer need to "configure" anything.The text was updated successfully, but these errors were encountered: