Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove distutils #38

Closed
wants to merge 1 commit into from
Closed

Conversation

jeongukjae
Copy link

Resolve #37

@mchinen
Copy link

mchinen commented Apr 4, 2022

See #37 for context. distutils is deprecated and causes issues on python 3.10 on windows. I think this should be merged.

@Mizux
Copy link

Mizux commented Apr 11, 2022

IMHO prefer to use a patch like it has been done in pybind11 so it will still work with python < 3.10

import sys
USE_SYSCONFIG = sys.version_info >= (3, 10)
if USE_SYSCONFIG:
  import sysconfig as s
  library_paths = [s.get_path("purelib")]
else:
  from distutils import sysconfig as ds
  library_paths = [ds.get_python_lib()]\n
import sys
USE_SYSCONFIG = sys.version_info >= (3, 10)
if USE_SYSCONFIG:
  import sysconfig as s
  print(s.get_path("include"))
else:
  from distutils import sysconfig as ds
  print(ds.get_python_inc())

@Mizux
Copy link

Mizux commented Apr 28, 2022

FYI https://github.com/google/or-tools/blob/master/patches/pybind11_bazel.patch
@maintainer|Googlers I can do a CL instead if it's easier to integrate...

@jblespiau
Copy link
Collaborator

Thank you, done in c982636

@jblespiau jblespiau closed this Sep 12, 2022
@jeongukjae jeongukjae deleted the remove-distutils branch September 12, 2022 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

python_configure fails with python 3.10
4 participants