Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add electrode balancing example #222

Closed
NicolaCourtier opened this issue Mar 1, 2024 · 6 comments · Fixed by #472
Closed

Add electrode balancing example #222

NicolaCourtier opened this issue Mar 1, 2024 · 6 comments · Fixed by #472
Assignees
Labels
difficulty:medium enhancement New feature or request

Comments

@NicolaCourtier
Copy link
Member

Feature description

Create an example workflow for fitting the electrode stoichiometry balance parameters from pseudo-OCV test data.

Motivation

To demonstrate and benchmark a common battery parameterisation problem.

Possible implementation

This could be implemented as an example script/notebook or as an extension of the FittingProblem class.

Additional context

No response

@NicolaCourtier NicolaCourtier added the enhancement New feature or request label Mar 1, 2024
@brosaplanella
Copy link
Contributor

Similar to my comment in GITT: #223 (comment). However, this one requires some extra work as our implementation do not conform to the PyBaMM model structure yet so it is a bit clunky (for ref https://github.com/paramm-team/pybamm-param/blob/develop/pbparam/optimisation_problems/OCP_balance.py). I know how the refactoring should go, just need to find some time to implement it.

@BradyPlanden
Copy link
Member

Assigned - @DrSOKane

@DrSOKane
Copy link

Would the half-cell OCP curves be given in terms of capacity or stoichiometry? Both work, but they're different optimization problems.

@BradyPlanden
Copy link
Member

Stoichiometry should allow for direct integration with PyBaMM, so that would be my preference.

@brosaplanella
Copy link
Contributor

brosaplanella commented Mar 25, 2024

In our implementation in pybamm-param (https://github.com/paramm-team/pybamm-param/blob/develop/examples/notebooks/ocp_balance.ipynb). which may be a good starting point, we took the reference OCP to be vs stoichiometry and the measured one to be vs capacity. The idea was that OCP in the lab is measured vs capacity but, as Brady said, the models require it to be vs stoichiometry.

@brosaplanella
Copy link
Contributor

brosaplanella commented Aug 22, 2024

Regarding this example, the main issue is how to implement the model. I am not sure I fully understand the standalone model, should I just inherit from that class and define a new evaluate function? Or what is the recommended way to proceed?

UPDATE: I think I found a hack with the ECM model

brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Aug 22, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Aug 25, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Aug 25, 2024
brosaplanella added a commit to brosaplanella/PyBOP that referenced this issue Aug 25, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in v24.9 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:medium enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants