Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VolumetricEnergyDensity example #191

Merged
merged 8 commits into from
Feb 9, 2024

Conversation

NicolaCourtier
Copy link
Member

@NicolaCourtier NicolaCourtier commented Feb 9, 2024

  • add VolumetricEnergyDensity
  • add cell_volume function
  • extend tests
  • update Changelog

@NicolaCourtier NicolaCourtier linked an issue Feb 9, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d3fa97f) 94.55% compared to head (1499994) 94.67%.
Report is 1 commits behind head on develop.

Files Patch % Lines
pybop/models/base_model.py 57.14% 3 Missing ⚠️
examples/scripts/spme_max_energy.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #191      +/-   ##
===========================================
+ Coverage    94.55%   94.67%   +0.11%     
===========================================
  Files           42       44       +2     
  Lines         1783     1823      +40     
===========================================
+ Hits          1686     1726      +40     
  Misses          97       97              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spot where we should probably update the tests to match the intended call structure. Otherwise, nice one - looks great!

tests/unit/test_cost.py Outdated Show resolved Hide resolved
tests/unit/test_cost.py Outdated Show resolved Hide resolved
tests/unit/test_cost.py Outdated Show resolved Hide resolved
@NicolaCourtier NicolaCourtier merged commit 7d09c5d into develop Feb 9, 2024
18 checks passed
@NicolaCourtier NicolaCourtier deleted the 190-volumetric-energy-density branch February 9, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add another design cost
2 participants