-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VolumetricEnergyDensity example #191
Conversation
NicolaCourtier
commented
Feb 9, 2024
•
edited
Loading
edited
- add VolumetricEnergyDensity
- add cell_volume function
- extend tests
- update Changelog
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #191 +/- ##
===========================================
+ Coverage 94.55% 94.67% +0.11%
===========================================
Files 42 44 +2
Lines 1783 1823 +40
===========================================
+ Hits 1686 1726 +40
Misses 97 97 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One spot where we should probably update the tests to match the intended call structure. Otherwise, nice one - looks great!