139b Add unit tests for plotting and Thevenin model #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 139-split-integration-unit-tests #212 +/- ##
=====================================================================
+ Coverage 81.97% 94.29% +12.32%
=====================================================================
Files 32 32
Lines 1614 1614
=====================================================================
+ Hits 1323 1522 +199
+ Misses 291 92 -199 ☔ View full report in Codecov by Sentry. |
BradyPlanden
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Thanks for the fast PR @NicolaCourtier! I've added a few comments, but looks great overall. I think we can use a fixture in test_models.py to avoid duplicating the parameterize block.
NicolaCourtier
merged commit 54e97f5
into
139-split-integration-unit-tests
31 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.