Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatype restructure for optimisation objects #224

Merged
merged 10 commits into from
Mar 13, 2024

add infeasible cost tests, remove redundant scipyminimise maxiter opt…

afd4990
Select commit
Loading
Failed to load commit list.
Merged

Datatype restructure for optimisation objects #224

add infeasible cost tests, remove redundant scipyminimise maxiter opt…
afd4990
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 13, 2024 in 0s

94.08% (+0.15%) compared to ed2bf7c

View this Pull Request on Codecov

94.08% (+0.15%) compared to ed2bf7c

Details

Codecov Report

Attention: Patch coverage is 93.60465% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 94.08%. Comparing base (ed2bf7c) to head (afd4990).

Files Patch % Lines
pybop/costs/fitting_costs.py 93.47% 3 Missing ⚠️
pybop/observers/observer.py 90.00% 3 Missing ⚠️
pybop/models/lithium_ion/echem_base.py 50.00% 2 Missing ⚠️
pybop/costs/design_costs.py 85.71% 1 Missing ⚠️
pybop/plotting/plot_cost2d.py 96.00% 1 Missing ⚠️
pybop/plotting/plot_problem.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           177b-plotting-capabilities     #224      +/-   ##
==============================================================
+ Coverage                       93.92%   94.08%   +0.15%     
==============================================================
  Files                              35       35              
  Lines                            1762     1826      +64     
==============================================================
+ Hits                             1655     1718      +63     
- Misses                            107      108       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.