Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental circuit model fitting notebook #241

Merged
merged 13 commits into from
Apr 6, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Mar 18, 2024

This PR does the following:

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue reference

Fixes #170

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: Adds notebook examples & data

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@BradyPlanden BradyPlanden linked an issue Mar 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.44%. Comparing base (5d5985d) to head (d5a550c).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #241      +/-   ##
===========================================
+ Coverage    95.42%   95.44%   +0.01%     
===========================================
  Files           36       36              
  Lines         1990     1998       +8     
===========================================
+ Hits          1899     1907       +8     
  Misses          91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden changed the title [WIP]: Add experimental circuit model fitting notebook Add experimental circuit model fitting notebook Apr 4, 2024
Copy link
Member

@NicolaCourtier NicolaCourtier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I'm approving with 2 very minor comments, thanks @BradyPlanden!

pybop/_dataset.py Outdated Show resolved Hide resolved
pybop/_dataset.py Outdated Show resolved Hide resolved
@BradyPlanden BradyPlanden merged commit 68c0e49 into develop Apr 6, 2024
31 checks passed
@BradyPlanden BradyPlanden deleted the 170-add-experimental-data-for-ecm-fitting branch April 6, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add experimental data for ECM fitting
2 participants