-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increment PyBaMM > 23.5
#252
Increment PyBaMM > 23.5
#252
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #252 +/- ##
========================================
Coverage 95.49% 95.49%
========================================
Files 38 38
Lines 2040 2040
========================================
Hits 1948 1948
Misses 92 92 ☔ View full report in Codecov by Sentry. |
…integration tests in parameterisation tests
c445aff
to
c7ef869
Compare
…est-failing-on-pybamm-235' into 251-bug-scheduled-test-failing-on-pybamm-235
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @BradyPlanden! Just a few comments.
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Description
Increments PyBaMM > 23.5 to ensure
pybamm.Thevenin
is usable within PyBOP and fixes the current failing scheduled tests.Issue reference
Fixes #251
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s docs
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.