-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to test PyBaMM develop branch nightly #291
Add workflow to test PyBaMM develop branch nightly #291
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #291 +/- ##
===========================================
+ Coverage 95.47% 95.49% +0.01%
===========================================
Files 36 38 +2
Lines 2034 2040 +6
===========================================
+ Hits 1942 1948 +6
Misses 92 92 ☔ View full report in Codecov by Sentry. |
schedule: | ||
- cron: "0 23 * * *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A daily schedule should be alright for now, but when we implement the nightlies on the PyBaMM side, I will suggest matching that (which will most likely be weekly) to run a few hours after PyBaMM's wheels will have been uploaded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will most likely be weekly or fortnightly, and I will further recommend adding a job that needs this job and creates an issue for you. Here's how xarray
started doing it, which is a bit complicated: pydata/xarray#4583 but it seems to work well: pydata/xarray#8844
We can use a similar workflow based on this, or implement a simpler job that doesn't need to parse the logs and so on. and use existing third-party GitHub Actions that can do the same task (opening an issue, adding the workflow URL in the contents, etc.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since I saw the cross-link: we've since moved on to using xarray-contrib/issue-from-pytest-log, which abstracts away a lot of the complex code and in general is a lot more robust.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks wonderful – thanks a lot, @keewis!
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think GitHub is a bit buggy today so I'm not sure if the diffs I suggested are loading correctly. But I think these should be all of the necessary changes.
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
Description
Adds a workflow to nightly test PyBOP against PyBaMM@develop. This should be used to capture how breaking changes from PyBaMM affect PyBOP.
This workflow can be viewed here: https://github.com/pybop-team/PyBOP/actions/runs/8672602634
Issue reference
Fixes #290
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.