-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Transformation class #357
Adds Transformation class #357
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #357 +/- ##
===========================================
+ Coverage 98.11% 98.28% +0.16%
===========================================
Files 44 46 +2
Lines 2708 2907 +199
===========================================
+ Hits 2657 2857 +200
+ Misses 51 50 -1 ☔ View full report in Codecov by Sentry. |
…, and composed transformations, updts for example API usage
3ba0b1f
to
4e1f845
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work implementing the transformation classes! To retain modularity, let's make transformation
a property of the Parameters class (as well as each Parameter) instead of the cost/optimiser.
…-scale-parameters # Conflicts: # pybop/costs/base_cost.py # pybop/costs/fitting_costs.py
…lue for multi_signal w/ gaussian likelihood
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BradyPlanden, transformations look like a useful addition!
3fd3ea3
to
8dca6d1
Compare
Description
Adds a transformation class for
BaseCost
classes. This class applies a transformation to the parameter space to a latent space for improved optimisation / sampling.Issue reference
Fixes #92
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.