Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v24.6.1 #415

Merged
merged 15 commits into from
Jul 31, 2024
Merged

Release v24.6.1 #415

merged 15 commits into from
Jul 31, 2024

Conversation

BradyPlanden
Copy link
Member

@BradyPlanden BradyPlanden commented Jul 22, 2024

Description

Patch release 24.6.1 with cherry picked commits from #313

This shouldn't be merged and released until PyBaMM v24.5 is live.

  • pybamm == v24.5rc2 -> pybamm == v24.5

Issue reference

Fixes # -

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.82%. Comparing base (97aba6f) to head (a318207).
Report is 613 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   97.78%   97.82%   +0.03%     
==========================================
  Files          43       43              
  Lines        2579     2579              
==========================================
+ Hits         2522     2523       +1     
+ Misses         57       56       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradyPlanden BradyPlanden changed the title Release v26.4.1 Release v24.6.1 Jul 31, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@BradyPlanden
Copy link
Member Author

BradyPlanden commented Jul 31, 2024

Scheduled is failing on Python 3.9, but we've fixed it in develop, so I'm happy for this release to proceed with v24.9 (or v24.8 tbh) fixing those issues.

@BradyPlanden BradyPlanden merged commit 737a4f8 into main Jul 31, 2024
46 of 51 checks passed
@BradyPlanden BradyPlanden deleted the patch-pybammv24.5 branch July 31, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants