-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v24.6.1 #415
Release v24.6.1 #415
Conversation
Changes to pybamm v24.5 have resulted in solver.solve() to return values for incorrect inputs values when not requesting sensitivities. This removes the test that assert output == np.inf in this case.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 97.78% 97.82% +0.03%
==========================================
Files 43 43
Lines 2579 2579
==========================================
+ Hits 2522 2523 +1
+ Misses 57 56 -1 ☔ View full report in Codecov by Sentry. |
Scheduled is failing on Python 3.9, but we've fixed it in |
Description
Patch release 24.6.1 with cherry picked commits from #313
This shouldn't be merged and released until PyBaMM v24.5 is live.
pybamm == v24.5rc2
->pybamm == v24.5
Issue reference
Fixes # -
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.