-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nbstripout pre-commit hook #428
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #428 +/- ##
========================================
Coverage 98.14% 98.14%
========================================
Files 44 44
Lines 2697 2697
========================================
Hits 2647 2647
Misses 50 50 ☔ View full report in Codecov by Sentry. |
Note that the failed project coverage check is simply due to the extra Changelog entry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes LGTM in principle; thank you, @NicolaCourtier!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks @NicolaCourtier! The patch coverage is down due to this flaky test: https://app.codecov.io/gh/pybop-team/PyBOP/pull/428/indirect-changes which I've fixed in #411:
PyBOP/tests/unit/test_optimisation.py
Line 427 in 7bae73c
# Reset optim |
I've left a few comments/suggestions, otherwise LGTM.
examples/notebooks/LG_M50_ECM/1-single-pulse-circuit-model.ipynb
Outdated
Show resolved
Hide resolved
Co-authored-by: Brady Planden <55357039+BradyPlanden@users.noreply.github.com>
Description
Add the nbstripout pre-commit hook from: https://github.com/kynan/nbstripout
Issue reference
Fixes #427
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.