-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformation fixes #495
Transformation fixes #495
Conversation
…st transformation arg in scipy_optimisers.py, updates transformation integration tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #495 +/- ##
========================================
Coverage 99.04% 99.04%
========================================
Files 52 52
Lines 3556 3559 +3
========================================
+ Hits 3522 3525 +3
Misses 34 34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @BradyPlanden, looks great. I think there is a danger in the lenght of the fail gradient becoming out of sync with the number of parameters in the base cost class, so would suggest a setter on the parameters
attribute, what do you think? Can be a separate issue as well if you don't want to deal with it now
Thanks for the review @martinjrobins, I agree that a setter in the |
… call to parameters.join(). Updts. fail_gradient within setter.
…r-gaussianloglikelihood
…uild()` initial_state dict keys to docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I think this is better. Should parameters
be renamed to `_parameters' to indicate that it shouldn't be set directly?
Description
apply_transform
arg in cost call for SciPy optimisers. Adds addition costs to transformation integration tests and general refactor.Issue reference
Fixes #492
Review
Before you mark your PR as ready for review, please ensure that you've considered the following:
Type of change
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ nox -s tests
$ nox -s doctest
You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
Thank you for contributing to our project! Your efforts help us to deliver great software.