Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: add crate skeleton for X.509 path validation #8873

Merged
merged 193 commits into from
Dec 22, 2023
Merged

rust: add crate skeleton for X.509 path validation #8873

merged 193 commits into from
Dec 22, 2023

Commits on Sep 7, 2023

  1. src, tests: flatten all changes 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    69eb9a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Merge remote-tracking branch 'origin/main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 2, 2023
    Configuration menu
    Copy the full SHA
    cb8a316 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. make cargo doc happy 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 3, 2023
    Configuration menu
    Copy the full SHA
    7e1f72a View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ade49a1 View commit details
    Browse the repository at this point in the history

  2. verify: move API to ServerVerifier.verify 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    30509a8 View commit details
    Browse the repository at this point in the history

  3. fix tests 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    4658f70 View commit details
    Browse the repository at this point in the history

  4. extensions: derive Eq 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1420533 View commit details
    Browse the repository at this point in the history

  5. policy: another Eq derive 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    43999ac View commit details
    Browse the repository at this point in the history

  6. [DEMO] declarative extension policies 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    c220117 View commit details
    Browse the repository at this point in the history

  7. more extension policy refactoring 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    25655ad View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. fixup tests 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    7c77155 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    352d9cf View commit details
    Browse the repository at this point in the history

  3. rust: support name constraints (#4) 

    * rust: WIP code to verify name constraints

* rust: get DNS name constraints working

* rust: fix DNS pattern match check

* lib: clippage

Signed-off-by: William Woodruff <william@trailofbits.com>

* lib: fmt

Signed-off-by: William Woodruff <william@trailofbits.com>

* WIP to store `GeneralName` directly

* lib: fmt

Signed-off-by: William Woodruff <william@trailofbits.com>

* lib: reuse Chain type

Signed-off-by: William Woodruff <william@trailofbits.com>

* extensions: drop unnecessary self lifetime bound (pyca#9650)

Signed-off-by: William Woodruff <william@trailofbits.com>

* validation: fix lifetimes

Signed-off-by: William Woodruff <william@trailofbits.com>

* certificate: increase lifetime precisions (pyca#9651)

Similar to pyca#9650: adding explicit lifetimes here prevents Rust
from binding `&self` to the placeholder lifetime, which it does
by default. The in turn allows the return values here to
outlive `&self`.

Signed-off-by: William Woodruff <william@trailofbits.com>

* Rename chain result to something more idiomatic

* Use default annotation for name constraints

* Simplify constraint subtree collection

* Create separate `DNSConstraint` type

* Add CA and EE name constraint checks

* rust: Revert `permits_leaf` refactor

* rust: Make name constraint matching slightly more correct

* rust: Fix `IPAddress._packed` call

* rust: Account for the case when an IP SAN doesn't represent a range

* rust: Refine name constraint logic for SANs

* rust: Use `matches!` macro

* rust: Don't apply name constraints to self-issued certs unless its the leaf

* DNSConstraint: newtype pattern

Signed-off-by: William Woodruff <william@trailofbits.com>

* oops

Signed-off-by: William Woodruff <william@trailofbits.com>

* types: refactor, test DNSConstraint

Signed-off-by: William Woodruff <william@trailofbits.com>

* types: another constraint test for good measure

Signed-off-by: William Woodruff <william@trailofbits.com>

---------

Signed-off-by: William Woodruff <william@trailofbits.com>
Co-authored-by: William Woodruff <william@trailofbits.com>
    @tetsuo-cpp @woodruffw
    tetsuo-cpp and woodruffw authored Oct 6, 2023
    Configuration menu
    Copy the full SHA
    b7205be View commit details
    Browse the repository at this point in the history

  4. types: clippage 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 6, 2023
    Configuration menu
    Copy the full SHA
    d663c07 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    0af2218 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. rust: check for malformed AuthorityInformationAccess extension (#5) 

    * rust: check for malformed `AuthorityInformationAccess` extension

* policy: do AIA check as an ExtensionPolicy

Signed-off-by: William Woodruff <william@trailofbits.com>

---------

Signed-off-by: William Woodruff <william@trailofbits.com>
Co-authored-by: William Woodruff <william@trailofbits.com>
    @tetsuo-cpp @woodruffw
    tetsuo-cpp and woodruffw authored Oct 16, 2023
    Configuration menu
    Copy the full SHA
    5285a9a View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    9713022 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    4de63fc View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. validation: refactor maybe_present extn handling 

    More expressive.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    2adf177 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    7f550db View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    71bd69d View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. tests: Add x509-limbo test (#1) 

    * tests: Add `x509-limbo` test

tests: Use subtests in `test_limbo`

Use the correct peer name types

tests: Flip the Limbo validation kind to `SERVER`

* tests: Update `limbo.json`

* tests: Fix Limbo tests that exercise unsupported features

* test: Use new server verifier API

* test: Don't allow empty peer name since the API requires it

* rust: Add name constraints OID to critical extensions list

* rust: Fix check for leaf certificates when applying name constraints

* test: Remove assert for `extended_key_usage` Limbo data since we're
populating it now

* test: Update `limbo.json`

* test: Skip EKU Limbo tests

* test: Add comments to explain why we're skipping certain Limbo tests

* rust: Leave comment explaining `is_leaf` parameter
    @tetsuo-cpp
    tetsuo-cpp authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    625fa41 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    4745642 View commit details
    Browse the repository at this point in the history

  3. rust: Use extension policy mechanism to check for unaccounted critica… 

    …l extensions (#6)

* rust: Use extension policy mechanism to check for unaccounted critical extensions

* validation/policy: slightly more efficient critical matching

Signed-off-by: William Woodruff <william@trailofbits.com>

---------

Signed-off-by: William Woodruff <william@trailofbits.com>
Co-authored-by: William Woodruff <william@trailofbits.com>
    @tetsuo-cpp @woodruffw
    tetsuo-cpp and woodruffw authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ba37c80 View commit details
    Browse the repository at this point in the history

  4. clippy fixes 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    21b8026 View commit details
    Browse the repository at this point in the history

  5. derive Eq 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    2232868 View commit details
    Browse the repository at this point in the history

  6. policy: clippage 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d91f976 View commit details
    Browse the repository at this point in the history

  7. remove double negative 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9e04a6a View commit details
    Browse the repository at this point in the history

  8. test_verification: move asserts 

    Free coverage.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0f21360 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2023

  1. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    9ff4070 View commit details
    Browse the repository at this point in the history

  2. drop unused From impl 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    8d9d223 View commit details
    Browse the repository at this point in the history

  3. Revert "drop unused From impl" 

    This reverts commit 8d9d223.
    @woodruffw
    woodruffw committed Oct 26, 2023
    Configuration menu
    Copy the full SHA
    5ef5ecb View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    9d46d04 View commit details
    Browse the repository at this point in the history

  2. fixup AKI handling, update limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    f02458e View commit details
    Browse the repository at this point in the history

  3. bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    95ac2e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2023

  1. bump limbo suite 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    5153a69 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f54ce64 View commit details
    Browse the repository at this point in the history

  2. validation/policy: clean up TODOs and NOTEs a bit 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    8a702a9 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f59cbed View commit details
    Browse the repository at this point in the history

  4. validation/policy: drop unreachable check 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    a356e05 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    9d5a313 View commit details
    Browse the repository at this point in the history

  2. policy: check for 0 SN explicitly 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    457df90 View commit details
    Browse the repository at this point in the history

  3. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c54bced View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5e72f8b View commit details
    Browse the repository at this point in the history

  5. WIP docs 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    c91e13f View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    7b8f5a3 View commit details
    Browse the repository at this point in the history

  7. verification: fixup docs 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    e8b4fbc View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. validation: make subject non-optional (#7) 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7aefd2a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    504dd59 View commit details
    Browse the repository at this point in the history

  3. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    34202c4 View commit details
    Browse the repository at this point in the history

  4. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    fb362bd View commit details
    Browse the repository at this point in the history

  5. validation/policies: turn permits_san into an extension validator (#8) 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw authored Nov 2, 2023
    Configuration menu
    Copy the full SHA
    ce4e907 View commit details
    Browse the repository at this point in the history

  6. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    daa512d View commit details
    Browse the repository at this point in the history

  7. validation: move v3 check to permits_basic 

    CABF asserts this for all certs, not just CA certs.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    53e6761 View commit details
    Browse the repository at this point in the history

  8. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0259030 View commit details
    Browse the repository at this point in the history

  9. validation: put EKU handling under ext handling 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a9a380f View commit details
    Browse the repository at this point in the history

  10. tests, vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a9d8dc9 View commit details
    Browse the repository at this point in the history

  11. fixup isort 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    199ba0d View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    956c1b8 View commit details
    Browse the repository at this point in the history

  2. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    52977bd View commit details
    Browse the repository at this point in the history

  3. validation: refactor depth checks 

    This should be easier to get coverage for.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a163676 View commit details
    Browse the repository at this point in the history

  4. mod: comment 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    b0d8477 View commit details
    Browse the repository at this point in the history

  5. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    a4f4ea9 View commit details
    Browse the repository at this point in the history

  6. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    58261a2 View commit details
    Browse the repository at this point in the history

  7. [WIP] vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    0282239 View commit details
    Browse the repository at this point in the history

  8. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    c086393 View commit details
    Browse the repository at this point in the history

  9. lib: Convert duplicate extension errors explicitly (#10)

    @facutuesca
    facutuesca authored Nov 3, 2023
    Configuration menu
    Copy the full SHA
    107c082 View commit details
    Browse the repository at this point in the history

  10. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    be6d3d8 View commit details
    Browse the repository at this point in the history

  11. lib: remove another From impl 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    36654c1 View commit details
    Browse the repository at this point in the history

  12. vectors: bump limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    6bed9db View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. vectors: bump limbo

    @facutuesca
    facutuesca committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    6d3714c View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    5afa0a7 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. validation: Add max_chain_depth parameter to ServerVerifier (#9) 

    * validation: Add `max_chain_depth` parameter to `ServerVerifier`

* test: Bump `limbo.json` and support `max_chain_depth` in the harness

* Bump `limbo.json`

* rust: Fix bad merge

* Bump `limbo.json`
    @tetsuo-cpp
    tetsuo-cpp authored Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7546674 View commit details
    Browse the repository at this point in the history

  2. test_verification: add already-set test for max_chain_depth 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    af0d43b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    acdf068 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e5d62a3 View commit details
    Browse the repository at this point in the history

  5. verification: fix bad merge 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    06e1be5 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    fe39fb9 View commit details
    Browse the repository at this point in the history

  7. remove commented code, redundant tests 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    329eed5 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    4017871 View commit details
    Browse the repository at this point in the history

  9. actions: add a fetch-limbo action 

    Not hooked up to anything yet.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    c0ec72f View commit details
    Browse the repository at this point in the history

  10. tests: prep limbo a la wycheproof 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    c270e4a View commit details
    Browse the repository at this point in the history

  11. tests: migrate limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    7434373 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'tob-generic-fetch-vectors' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    363dee3 View commit details
    Browse the repository at this point in the history

  13. ci: use fetch-limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    efc8f29 View commit details
    Browse the repository at this point in the history

  14. remove hardcopied limbo 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    3e838c7 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    79fe0b4 View commit details
    Browse the repository at this point in the history

  2. tests: remove test_verify_basic 

    Now covered by limbo.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f7fdeaf View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    913f723 View commit details
    Browse the repository at this point in the history

  4. validation/certificate: remove dead_code attrs 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    ab7de49 View commit details
    Browse the repository at this point in the history

  5. validation/extension: remove more dead_code attrs 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    421594a View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    8fd2684 View commit details
    Browse the repository at this point in the history

  2. verify: simplify types 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    ef9061f View commit details
    Browse the repository at this point in the history

  3. document, enforce chain order 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    bf3b3cb View commit details
    Browse the repository at this point in the history

  4. lib: simplify is_match 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    ea88d53 View commit details
    Browse the repository at this point in the history

  5. Update src/rust/cryptography-x509-validation/src/lib.rs 

    Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>
    @woodruffw @alex
    woodruffw and alex authored Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7bfab59 View commit details
    Browse the repository at this point in the history

  6. validation/lib: return impl iterator 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    97c551f View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    db05265 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    669bb22 View commit details
    Browse the repository at this point in the history

  9. validation/ops: remove old coverage stub 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    af14ec4 View commit details
    Browse the repository at this point in the history

  10. test_limbo: remove assert messages 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    eac3a07 View commit details
    Browse the repository at this point in the history

  11. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    af29fec View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    4168322 View commit details
    Browse the repository at this point in the history

  13. drastically simplify lifetimes 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    062a64b View commit details
    Browse the repository at this point in the history

  14. test_verification: remove unused import 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    ace8142 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2023

  1. validation/lib: Remove unnecessary AccumulatedNameConstraints type

    @tetsuo-cpp
    tetsuo-cpp committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    9793bb2 View commit details
    Browse the repository at this point in the history

  2. validation/lib: Use cert_is_self_issued for potential issuers

    @tetsuo-cpp
    tetsuo-cpp committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    d498f67 View commit details
    Browse the repository at this point in the history

  3. validation/lib: Flip condition

    @tetsuo-cpp
    tetsuo-cpp committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2f52dd0 View commit details
    Browse the repository at this point in the history

  4. validation/lib: Use cert_is_self_signed

    @tetsuo-cpp
    tetsuo-cpp committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c40761f View commit details
    Browse the repository at this point in the history

  5. validation/lib: Reduce calls to Certificate::extensions

    @tetsuo-cpp
    tetsuo-cpp committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    e0c377d View commit details
    Browse the repository at this point in the history

  6. validation/lib: Remove more calls to extensions

    @tetsuo-cpp
    tetsuo-cpp committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    269ef79 View commit details
    Browse the repository at this point in the history

  7. validation/policy: Check for overflow of current depth

    @tetsuo-cpp
    tetsuo-cpp committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    90162e4 View commit details
    Browse the repository at this point in the history

  8. validation/policy: Check validity dates for generalized date cutoff

    @tetsuo-cpp
    tetsuo-cpp committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    adc7333 View commit details
    Browse the repository at this point in the history

  9. validation/policy: Check for negative serial numbers

    @tetsuo-cpp
    tetsuo-cpp committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    0c5ff83 View commit details
    Browse the repository at this point in the history

  10. validation: only check spki and signature_alg when verifying sigs 

    This is consistent with how other path validation libraries behave.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    2ce7a34 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. validation: add API TODO 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    0f6214f View commit details
    Browse the repository at this point in the history

  2. test_limbo: more features 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    55e82f7 View commit details
    Browse the repository at this point in the history

  3. policy/extension: allow missing AKI on CAs 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    bf12b48 View commit details
    Browse the repository at this point in the history

  4. tests/limbo: skip webpki::aki::root-with-aki-ski-mismatch 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    e665d3b View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    a14634d View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. tests: Remove pedantic-webpki from unsupported list

    @tetsuo-cpp
    tetsuo-cpp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    ba7dbf3 View commit details
    Browse the repository at this point in the history

  2. validation/policy: Remove unused conversion

    @tetsuo-cpp
    tetsuo-cpp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    8d06d26 View commit details
    Browse the repository at this point in the history

  3. validation/policy: Add unit tests for validity dates

    @tetsuo-cpp
    tetsuo-cpp committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    0d98eaf View commit details
    Browse the repository at this point in the history

  4. ci: remove a line 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    6be1f50 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    76abe1f View commit details
    Browse the repository at this point in the history

  6. validation: flatten error types 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    09377a5 View commit details
    Browse the repository at this point in the history

  7. validation: remove unnecessary From impls 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    1a4cf74 View commit details
    Browse the repository at this point in the history

  8. validation: render OIDs in a few errors 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    e93bc07 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into tob-x509-cv-skeleton 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    0cf2e52 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    c9642e9 View commit details
    Browse the repository at this point in the history

  11. validation/policy: free coverage 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    6c577be View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2023

  1. validation/policy: ok_or_else (no escaping the coverage gods) 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 18, 2023
    Configuration menu
    Copy the full SHA
    a860232 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. validation/policy: remove no-op branch 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    d231e1e View commit details
    Browse the repository at this point in the history

  2. validation: add EKU note 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    7b4c2c0 View commit details
    Browse the repository at this point in the history

  3. validation: add invariant-preserving Intermediates type 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    5ee09e5 View commit details
    Browse the repository at this point in the history

  4. validation: better error message 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    bd1553f View commit details
    Browse the repository at this point in the history

  5. invert conditions 

    Oops.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    89067e2 View commit details
    Browse the repository at this point in the history

  6. validation: rewrite error handling 

    Plumb penultimate errors through the validation cycle.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    adeb62d View commit details
    Browse the repository at this point in the history

  7. lib: misleading comment 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    518da01 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. test_limbo: handle IPv6 addresses correctly 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f964ce7 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. test_limbo: add another feature flag 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    48af1c5 View commit details
    Browse the repository at this point in the history

  2. validation/extensions: add some NC checks 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c79f40b View commit details
    Browse the repository at this point in the history

  3. lintage 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a29c73e View commit details
    Browse the repository at this point in the history

  4. validation/extension: fix subtree check 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    bab3d2a View commit details
    Browse the repository at this point in the history

  5. validation/extension: remove pedantic check 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    8135121 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    b3ae108 View commit details
    Browse the repository at this point in the history

  2. validation: avoid an intermediate vector 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    31d7d81 View commit details
    Browse the repository at this point in the history

  3. validation: &Vec<_> -> &[_] 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d294958 View commit details
    Browse the repository at this point in the history

  4. validation: search the store first 

    Effectively means that we'll prefer shorter chains.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d1b0a33 View commit details
    Browse the repository at this point in the history

  5. validation: simplify match 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    6c2eafe View commit details
    Browse the repository at this point in the history

  6. validation: rename IntermediateChain -> PartialChainState 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    f591c12 View commit details
    Browse the repository at this point in the history

  7. policy/extension: add a NOTE about pathLength validation 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    1adf14f View commit details
    Browse the repository at this point in the history

  8. tests/x509: restructure verification tests 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9ce06d0 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2023

  1. test_limbo: update ID 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    030b79f View commit details
    Browse the repository at this point in the history

  2. validation: expand NC skip comment 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    b6de1f9 View commit details
    Browse the repository at this point in the history

  3. validation: fixup NC handling, expose NC errors 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    6e6d7c7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    120daf5 View commit details
    Browse the repository at this point in the history

  5. validation: remove unreachable error case 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    6607e75 View commit details
    Browse the repository at this point in the history

  6. validation: remove unnecessary clone 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 24, 2023
    Configuration menu
    Copy the full SHA
    24ecf76 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2023

  1. validation: handle malformed SANs in NC checking 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    3060a70 View commit details
    Browse the repository at this point in the history

  2. validation: allow SN==0 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    e1ee967 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2023

  1. validation: remove redundant branch 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    642e72e View commit details
    Browse the repository at this point in the history

  2. validation: relax SKI check on CA certs 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    c6d502e View commit details
    Browse the repository at this point in the history

  3. validation: document BC handling 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    e26feb8 View commit details
    Browse the repository at this point in the history

  4. validation: document precondition on valid_issuer 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    b1e8d2a View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2023

  1. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    91c30d5 View commit details
    Browse the repository at this point in the history

  2. validation: make EKU in EEs optional 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    dcc7069 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. validation: make EKU handling common 

    This makes us handle EKU constraints in CAs, which the Web PKI
stipulates.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    1ed7c2b View commit details
    Browse the repository at this point in the history

  2. [WIP] validation: refactor name constraints handling 

    Signed-off-by: William Woodruff <william@trailofbits.com>

tests: debugging assistance

Signed-off-by: William Woodruff <william@trailofbits.com>

validation: only accumulate NC if applied

Need to refactor this a bit, but it's functionally correct.

Signed-off-by: William Woodruff <william@trailofbits.com>

validation: cleanup, docs

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    e4c33bb View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Merge remote-tracking branch 'upstream/main' into tob-x509-cv-skeleton

    @woodruffw
    woodruffw committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    98d5502 View commit details
    Browse the repository at this point in the history

  2. src, tests: remove self-issued special-casing 

    Self-issued intermediates are now counted for pathlen and
max chain length purposes. This is nominally an RFC 5280 violation,
but one that is widely performed by path validation implementations.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    baaeeb2 View commit details
    Browse the repository at this point in the history

  3. lintage 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    6c886b5 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. validation: remove NullOps 

    Easier to reuse PublicKeyErrorOps, since we're not relying
on its APIs.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    a167fd2 View commit details
    Browse the repository at this point in the history

  2. validation: feedback 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    9926b98 View commit details
    Browse the repository at this point in the history

  3. validation: remove unnecessary second loop 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    d4a876f View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. tests/limbo: fixup schema assertions 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    474a925 View commit details
    Browse the repository at this point in the history

  2. validation: remove no-op match 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    8152578 View commit details
    Browse the repository at this point in the history

  3. Update src/rust/cryptography-x509-validation/src/policy/mod.rs 

    Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>
    @woodruffw @alex
    woodruffw and alex authored Dec 20, 2023
    Configuration menu
    Copy the full SHA
    5244884 View commit details
    Browse the repository at this point in the history

  4. policy: u64::from 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    be84030 View commit details
    Browse the repository at this point in the history

  5. test_limbo: assert that intermediates come from untrusted_intermediates 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    27b2b0d View commit details
    Browse the repository at this point in the history

  6. validation: simplify match exprs 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    0220e93 View commit details
    Browse the repository at this point in the history

  7. lib: apply_inner -> apply_single_constraint 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    35de5fd View commit details
    Browse the repository at this point in the history

  8. test_limbo: open limbo.json in binary mode 

    Unclear why this suddenly broke on Windows.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    07f2445 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. validation: simplify, fix NC validation 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    d5b8a45 View commit details
    Browse the repository at this point in the history

  2. lib: remove unused default derive 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    c52b597 View commit details
    Browse the repository at this point in the history

  3. policy: add NOTE, relax EKU check 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    6e7379a View commit details
    Browse the repository at this point in the history

  4. validation: move SAN matching to permits_leaf 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    7830bad View commit details
    Browse the repository at this point in the history

  5. break apart EKU handling by EE/CA 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    e16a347 View commit details
    Browse the repository at this point in the history

  6. validation: reorder permits_leaf for coverage 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    1e00199 View commit details
    Browse the repository at this point in the history

  7. src, tests: remove CA-in-leaf-position support 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    fee2aa3 View commit details
    Browse the repository at this point in the history

  8. validation: unwrap and explain why 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    b65d12f View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. validation: remove permits_leaf entirely 

    Just call permits_ee directly.

Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    6aa642c View commit details
    Browse the repository at this point in the history

  2. validation/policy: fix validity_date GeneralizedTime check 

    Signed-off-by: William Woodruff <william@trailofbits.com>
    @woodruffw
    woodruffw committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    0fc7327 View commit details
    Browse the repository at this point in the history