Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ChaCha20Poly1305 AEAD to Rust #9399

Merged
merged 2 commits into from
Jan 13, 2024
Merged

Migrate ChaCha20Poly1305 AEAD to Rust #9399

merged 2 commits into from
Jan 13, 2024

Conversation

alex
Copy link
Member

@alex alex commented Aug 10, 2023 •
edited
Loading

@alex alex force-pushed the chacha20poly1305-rust branch from 4137295 to cbcdb88 Compare August 14, 2023 12:49
@alex alex mentioned this pull request Aug 21, 2023
Closed
22 tasks
@alex alex force-pushed the chacha20poly1305-rust branch 2 times, most recently from b5beafc to 9e9ddb1 Compare August 27, 2023 16:14
@alex
Copy link
Member Author

alex commented Aug 27, 2023

Grumble, not working due to openssl/openssl#21853

@alex alex force-pushed the chacha20poly1305-rust branch 2 times, most recently from e13d325 to d494ddf Compare September 5, 2023 21:46
@alex alex force-pushed the chacha20poly1305-rust branch 5 times, most recently from 88e7325 to 85b8852 Compare September 19, 2023 18:17
@alex alex force-pushed the chacha20poly1305-rust branch 2 times, most recently from 035e0ab to 34a6b82 Compare November 1, 2023 21:37
@alex alex force-pushed the chacha20poly1305-rust branch from 34a6b82 to cdf2d7a Compare November 24, 2023 21:45
@alex alex force-pushed the chacha20poly1305-rust branch from cdf2d7a to 1df836a Compare December 2, 2023 22:05
@alex alex force-pushed the chacha20poly1305-rust branch 2 times, most recently from 33cb870 to 76553bc Compare January 12, 2024 23:10
@alex
Copy link
Member Author

alex commented Jan 12, 2024

This disable ctx reuse on OpenSSL 3.0-3.2. There's a bunch of code we can delete once we support only versions with workign copies.

Even with the ctx reuse disabled on 3.0.2, which is used in the benchmarks, it's 20% faster than main.

@alex alex marked this pull request as ready for review January 12, 2024 23:16
@alex alex added this to the Forty Second Release milestone Jan 12, 2024
@alex alex force-pushed the chacha20poly1305-rust branch from 76553bc to 272dd6b Compare January 12, 2024 23:21
@alex alex force-pushed the chacha20poly1305-rust branch from 272dd6b to 73614ab Compare January 12, 2024 23:28
@reaperhulk
Copy link
Member

Do we use fixedpool anywhere now that this PR removes it from chacha?

@alex
Copy link
Member Author

alex commented Jan 13, 2024

Nope. Will remove it.

@reaperhulk
Copy link
Member

I do not envy future us looking at those conditionals.

@reaperhulk reaperhulk merged commit 94e5167 into pyca:main Jan 13, 2024
58 checks passed
@alex alex deleted the chacha20poly1305-rust branch January 13, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperhulk reaperhulk reaperhulk approved these changes

Assignees
No one assigned
Labels
blocked-on-upstream
Milestone
Forty Second Release
Development

Successfully merging this pull request may close these issues.
2 participants
@alex @reaperhulk