Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that secretbox can accept any bytes-like object as parameter #847

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Ensure that secretbox can accept any bytes-like object as parameter #847

wants to merge 6 commits into from

Conversation

blast-hardcheese
Copy link

start to address #707, ensuring that secretbox can accept bytearray.

The issue I ran into in this case was that both mypy and pyright think that bytearray satisfy bytes. Taking the suggestion from #707 resolved this in tests.

Thank you for the library!

@blast-hardcheese blast-hardcheese force-pushed the secretbox-bytearray branch 3 times, most recently from d39a50d to 7e60497 Compare November 12, 2024 20:20
@blast-hardcheese
Copy link
Author

Please pardon the force pushes. I'm also happy to remove mypy from optional-dependencies.tests if desired.

I was able to use uv to do most of my iteration here, but not having an explicit version of mypy specified prevented typechecking locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blast-hardcheese @ryantm