Fix various issues around X509_STORE_CTX reuse #1272
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is three commits that probably should be reviewed separately. The first is a minimal fix for a weird behavior in pyOpenSSL: inspecting an X509_STORE_CTX after you have cleaned it up is pretty odd.
The next two rework X509StoreContext to just create a new X509_STORE_CTX for each verification, which avoids a whole lot of historical mess around X509_STORE_CTX's transition from being stack-allocated to heap-allocated in the OpenSSL API.