Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tox and readthedocs #221

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Fix tox and readthedocs #221

merged 3 commits into from
Dec 11, 2023

Conversation

hartwork
Copy link
Collaborator

@hartwork hartwork commented Sep 5, 2023 •
edited by ssbarnea
Loading

Related #219
Related #220

@hartwork hartwork requested a review from ssbarnea as a code owner September 5, 2023 14:41
@hartwork hartwork changed the title Fix tox (to unblock dependency bump pull requests and #219 and #220) Fix tox (to unblock dependency bump pull requests #219 and #220) Sep 5, 2023
@hartwork hartwork added the enhancement This issue/PR relates to a feature request. label Sep 5, 2023
@github-actions github-actions bot added the bug This issue/PR relates to a bug. label Sep 5, 2023
@hartwork hartwork added skip-changelog Can be missed from the changelog. and removed enhancement This issue/PR relates to a feature request. labels Sep 5, 2023
@hartwork
readthedocs.yml: Remove discontinued key "python.system_packages"
574de69 
Error was:

> Problem in your project's configuration. Invalid configuration option
> "python.system_packages". This configuration key has been deprecated
> and removed. Refer to https://blog.readthedocs.com/use-system-packages-deprecated/
> to read more about this change and how to upgrade your config file.

Build log at https://readthedocs.org/projects/ansi2html/builds/21826996/ .

Upstream docs at https://blog.readthedocs.com/drop-support-system-packages/ .
Fix may be incomplete and may need a closer look.
@hartwork hartwork changed the title Fix tox (to unblock dependency bump pull requests #219 and #220) Fix tox and readthedocs (to unblock dependency bump pull requests #219 and #220) Sep 8, 2023
@hartwork
Copy link
Collaborator Author

hartwork commented Sep 8, 2023

@ssbarnea any chance you could give this a thumbs up to unblock the project?

This was referenced Sep 8, 2023
Closed
Closed
@hartwork hartwork mentioned this pull request Nov 5, 2023
Closed
@ssbarnea ssbarnea changed the title Fix tox and readthedocs (to unblock dependency bump pull requests #219 and #220) Fix tox and readthedocs Dec 11, 2023
@ssbarnea ssbarnea removed the bug This issue/PR relates to a bug. label Dec 11, 2023
@ssbarnea ssbarnea merged commit 3a2d0b6 into pycontribs:main Dec 11, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssbarnea ssbarnea ssbarnea approved these changes

Assignees
No one assigned
Labels
skip-changelog Can be missed from the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hartwork @ssbarnea