Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated linux_distribution() method #34

Merged
merged 1 commit into from
Oct 23, 2019
Merged

Replace deprecated linux_distribution() method #34

merged 1 commit into from
Oct 23, 2019

Conversation

tadeboro
Copy link
Contributor

As noted in the official documentation [1], linux_distribution method is deprecated and will be removed from Python 3.8.

In order to keep the existing functionality, we introduced distro package dependency that is linked from the official documentation.

[1] https://docs.python.org/3.7/library/platform.html

As noted in the official documentation [1], linux_distribution method
is deprecated and will be removed from Python 3.8.

In order to keep the existing functionality, we introduced distro
package dependency that is linked from the official documentation.

[1] https://docs.python.org/3.7/library/platform.html
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I did not fully test it. We should also have another PR to enable execution on py38.
One issue is that I doubt we have selinux on py38.

@ssbarnea ssbarnea added the enhancement New feature or request label Oct 23, 2019
@ssbarnea ssbarnea merged commit dde60d0 into pycontribs:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants