Make test_run_string pass when the default shell is not bash
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssbarnea
approved these changes
Dec 5, 2024
ssbarnea
added
skip-changelog
My default shell is fish (https://fishshell.com). `test_run_string` failed on my laptop because the `cmd` was not valid fish syntax. One option is to find a command which is similar to what was there but works in bash and other shells. Another option, the one I went with, was to always call bash. # Conflicts: # test/test_unit.py
ssbarnea
force-pushed
the
fix-test-fish
branch
from
2346454 to
ff73138
Compare
ssbarnea
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My default shell is fish (https://fishshell.com).
test_run_stringfailed on my laptop because thecmdwas not valid fish syntax.One option is to find a command which is similar to what was there but works in bash and other shells. Another option, the one I went with, was to always call bash.