Capture httpx response JSON bodies #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 137 137
Lines 10929 11008 +79
Branches 1524 1537 +13
=========================================
+ Hits 10929 11008 +79 ☔ View full report in Codecov by Sentry. |
Deploying logfire-docs with
|
| Latest commit: |
c873e48
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://827f3346.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-httpx-response-json.logfire-docs.pages.dev |
Kludex
reviewed
Dec 19, 2024
Comment on lines
+386
to
+406
| 'http.request.header.host': ('example.org',), | ||
| 'http.request.header.accept': ('*/*',), | ||
| 'http.request.header.accept-encoding': ('gzip, deflate',), | ||
| 'http.request.header.connection': ('keep-alive',), | ||
| 'http.request.header.user-agent': (IsStr(),), | ||
| 'http.request.header.content-length': (IsStr(),), | ||
| 'http.request.header.content-type': ('application/json',), | ||
| 'logfire.json_schema': '{"type":"object","properties":{"http.request.body.json":{"type":"object"}}}', | ||
| 'http.request.body.json': '{"hello":"world"}', | ||
| 'http.status_code': 200, | ||
| 'http.response.status_code': 200, | ||
| 'http.flavor': '1.1', | ||
| 'network.protocol.version': '1.1', | ||
| 'http.response.header.host': ('example.org',), | ||
| 'http.response.header.accept': ('*/*',), | ||
| 'http.response.header.accept-encoding': ('gzip, deflate',), | ||
| 'http.response.header.connection': ('keep-alive',), | ||
| 'http.response.header.user-agent': (IsStr(),), | ||
| 'http.response.header.content-length': (IsStr(),), | ||
| 'http.response.header.content-type': ('application/json',), | ||
| 'http.response.header.traceparent': ('00-00000000000000000000000000000001-0000000000000003-01',), |
There was a problem hiding this comment.
Isn't it a bit weird that you have both the information about the request headers, body and response headers in a single span, but the response body on another one? 🤔
There was a problem hiding this comment.
By the time the body is read, the main span is already closed, which is why a new span is needed.
The best we can do for now is to copy the attributes from the main span into the new span so that the new span has everything. But we can't put the body in the main span.
Kludex
approved these changes
Dec 19, 2024
Kludex
approved these changes
Dec 20, 2024
| await run_async_hook(hook, span, request, response) | ||
|
|
||
| return new_hook | ||
|
|
||
|
|
||
| def capture_response_json(logfire_instance: Logfire, response_info: ResponseInfo, is_async: bool) -> None: | ||
| headers = cast('httpx.Headers', response_info.headers) | ||
| if not headers.get('content-type', '').lower().startswith('application/json'): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.