Refactor httpx content type handling #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmojaki
commented
Dec 23, 2024
Comment on lines
+413
to
+445
| TEXT_SUBTYPES = { | ||
| 'json', | ||
| 'jsonp', | ||
| 'json-p', | ||
| 'javascript', | ||
| 'jsonl', | ||
| 'json-l', | ||
| 'jsonlines', | ||
| 'json-lines', | ||
| 'ndjson', | ||
| 'nd-json', | ||
| 'json5', | ||
| 'json-5', | ||
| 'xml', | ||
| 'xhtml', | ||
| 'html', | ||
| 'csv', | ||
| 'tsv', | ||
| 'yaml', | ||
| 'yml', | ||
| 'toml', | ||
| } | ||
|
|
||
|
|
||
| @lru_cache | ||
| def is_text_type(content_type: str) -> bool: | ||
| header = content_type_header_from_string(content_type) | ||
| if header.maintype == 'text': | ||
| return True | ||
| if header.maintype != 'application': | ||
| return False | ||
|
|
||
| return bool(content_type_subtypes(header.subtype) & TEXT_SUBTYPES) |
There was a problem hiding this comment.
This isn't used yet.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 138 138
Lines 11088 11128 +40
Branches 1548 1554 +6
=========================================
+ Hits 11088 11128 +40 ☔ View full report in Codecov by Sentry. |
Deploying logfire-docs with
|
| Latest commit: |
628e254
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://40c9aff2.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-capture-text.logfire-docs.pages.dev |
Kludex
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some initial work towards capturing text bodies. Currently nothing here should affect users (except that it can handle variations of
application/jsonsuch asapplication/ld+jsonwhich is a good fix) but I see overlap with #719 so I want to merge this.