capture_request_text_body
#722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #722 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 138 138
Lines 11128 11170 +42
Branches 1554 1567 +13
=========================================
+ Hits 11128 11170 +42 ☔ View full report in Codecov by Sentry. |
Deploying logfire-docs with
|
| Latest commit: |
d7583fe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4809259.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-httpx-text-2.logfire-docs.pages.dev |
Kludex
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a new class
LogfireHttpxRequestInfothat wraps the original OTELRequestInfoand adds lots of tiny methods and properties breaking down the logic of capturing various things. The idea is that users could use this to easily build their own variations in hooks. Planning to do the same for responses.