Skip to content

Commit

Permalink
Attempt fix - release build failed, need to install `typing-extension…
Browse files Browse the repository at this point in the history
…s` from main until a version after v4.12.1 (#1313)
  • Loading branch information
sydney-runkle authored Jun 3, 2024
1 parent 37ad925 commit 51ac71a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
6 changes: 0 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,6 @@ jobs:
python-version: ${{ matrix.python-version }}

- run: pip install -r tests/requirements.txt
# TODO: remove this after the the next release of typing-extensions (v4.12.3 or v.4.13.0)
- run: pip uninstall -y typing-extensions
- run: pip install -U git+https://github.com/python/typing_extensions@main

- run: pip install -e .
env:
Expand Down Expand Up @@ -662,10 +659,8 @@ jobs:
fi
run: |
set -x
# typing-extensions isn't automatically installed because of `--no-index --no-deps`
python3 -m venv venv
source venv/bin/activate
python3 -m pip install -U pip typing-extensions
python3 -m pip install -r tests/requirements.txt
python3 -m pip install pydantic-core --no-index --no-deps --find-links dist --force-reinstall
python3 -m pytest --ignore=tests/test_docstrings.py
Expand Down Expand Up @@ -696,7 +691,6 @@ jobs:
merge-multiple: true
path: dist

- run: pip install typing-extensions
- run: pip install -r tests/requirements.txt
- run: pip install pydantic-core --no-index --no-deps --find-links dist --force-reinstall
- run: pytest --ignore=tests/test_docstrings.py
Expand Down
2 changes: 2 additions & 0 deletions tests/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@ pytest-timeout==2.3.1
numpy==1.26.2; python_version >= "3.9" and python_version < "3.13" and implementation_name == "cpython" and platform_machine == 'x86_64'
exceptiongroup==1.1; python_version < "3.11"
tzdata==2024.1
# TODO: remove manual override for typing_extensions once a version newer than 4.12.1 is released
git+https://github.com/python/typing_extensions@main

0 comments on commit 51ac71a

Please sign in to comment.