Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower MSRV to 1.75 #1316

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Lower MSRV to 1.75 #1316

merged 1 commit into from
Jun 5, 2024

Conversation

tiran
Copy link
Contributor

@tiran tiran commented Jun 5, 2024

Change Summary

Lower MSRV to 1.75. Rust 1.75 is the lowest working Rust version.

Related issue number

fix: #1315

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @samuelcolvin

Rust 1.75 is the lowest working Rust version.

Signed-off-by: Christian Heimes <christian@python.org>
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@tiran
Copy link
Contributor Author

tiran commented Jun 5, 2024

please review

MSRV is not mentioned in README.md and there are no tests beyond the "test MSRV" job. Lowering MSRV should not have an impact on pydantic tests, either.

Copy link

codspeed-hq bot commented Jun 5, 2024

CodSpeed Performance Report

Merging #1316 will not alter performance

Comparing tiran:lower-msrv (9f2014d) with main (77f2b69)

Summary

✅ 155 untouched benchmarks

Copy link
Contributor

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, agreed! I think in my head I needed return-position-impl-trait-in-trait from 1.76, but you're right this came in 1.75 🙈

For what it's worth it would be possible to make <1.75 work, but it'd be a lot more effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lower MSRV to 1.75
3 participants