Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates rust type #82

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Dates rust type #82

merged 3 commits into from
Jun 14, 2022

Conversation

samuelcolvin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #82 (6516665) into dates (b25e2bb) will decrease coverage by 0.96%.
The diff coverage is 81.19%.

@@            Coverage Diff             @@
##            dates      #82      +/-   ##
==========================================
- Coverage   92.29%   91.33%   -0.97%     
==========================================
  Files          35       36       +1     
  Lines        2896     2955      +59     
  Branches       20       20              
==========================================
+ Hits         2673     2699      +26     
- Misses        223      256      +33     
Impacted Files Coverage Δ
src/input/shared.rs 100.00% <ø> (+6.12%) ⬆️
src/input/datetime.rs 74.54% <74.54%> (ø)
src/validators/datetime.rs 84.74% <79.41%> (-8.59%) ⬇️
src/validators/date.rs 89.24% <88.23%> (-6.31%) ⬇️
src/input/input_python.rs 86.84% <92.85%> (-0.47%) ⬇️
src/input/input_abstract.rs 100.00% <100.00%> (ø)
src/input/input_json.rs 96.70% <100.00%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25e2bb...6516665. Read the comment docs.

@samuelcolvin samuelcolvin marked this pull request as ready for review June 14, 2022 10:54
@samuelcolvin samuelcolvin merged commit d0eb564 into dates Jun 14, 2022
@samuelcolvin samuelcolvin deleted the dates-rust-type branch June 14, 2022 10:54
samuelcolvin added a commit that referenced this pull request Jun 14, 2022
* starting date parsing

* basic date parsing working

* fix tests

* improve coverage

* datetime parsing working

* working on datetime fallback for date errors

* fixing date parsing from datetimes

* adding datetime benchmarks

* fix edge case, more tests

* Dates rust type (#82)

* using speedate types for all dates

* using enum

* more datetime tests

* speedup by creating Date and DateTime from attributes

* implementing time types

* lax datetime tests and datetime from date

* python types and alter error kinds

* improving coverage

* more coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant