Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frozenset type #86

Merged
merged 11 commits into from
Jun 20, 2022
Merged

Add frozenset type #86

merged 11 commits into from
Jun 20, 2022

Conversation

dswij
Copy link
Contributor

@dswij dswij commented Jun 15, 2022

Part of #9

Mostly taken from Set since both Set and FrozenSet are almost identical from pydantic POV.

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #86 (b432dab) into main (77b7ae6) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   94.68%   94.78%   +0.10%     
==========================================
  Files          39       40       +1     
  Lines        3404     3454      +50     
  Branches       26       27       +1     
==========================================
+ Hits         3223     3274      +51     
+ Misses        181      180       -1     
Impacted Files Coverage Δ
src/errors/kinds.rs 100.00% <ø> (ø)
src/validators/set.rs 97.91% <ø> (-0.48%) ⬇️
src/validators/tuple.rs 98.48% <ø> (-0.15%) ⬇️
pydantic_core/_types.py 100.00% <100.00%> (ø)
src/input/input_abstract.rs 100.00% <100.00%> (ø)
src/input/input_json.rs 97.18% <100.00%> (+0.10%) ⬆️
src/input/input_python.rs 93.65% <100.00%> (+0.37%) ⬆️
src/validators/frozenset.rs 100.00% <100.00%> (ø)
src/validators/list.rs 75.80% <100.00%> (ø)
src/validators/mod.rs 98.31% <100.00%> (+0.01%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77b7ae6...b432dab. Read the comment docs.

@dswij dswij marked this pull request as ready for review June 16, 2022 13:32
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few things, otherwise this is looking great.

src/input/input_json.rs Outdated Show resolved Hide resolved
pydantic_core/_types.py Outdated Show resolved Hide resolved
tests/test_benchmarks.py Outdated Show resolved Hide resolved
tests/test_benchmarks.py Outdated Show resolved Hide resolved
src/input/input_json.rs Outdated Show resolved Hide resolved
tests/validators/test_frozenset.py Outdated Show resolved Hide resolved
tests/validators/test_frozenset.py Outdated Show resolved Hide resolved
tests/validators/test_frozenset.py Show resolved Hide resolved
@samuelcolvin
Copy link
Member

looks like tests are not running because of conflicts.

1 similar comment
@samuelcolvin
Copy link
Member

looks like tests are not running because of conflicts.

@samuelcolvin samuelcolvin merged commit e4f19a0 into pydantic:main Jun 20, 2022
@samuelcolvin
Copy link
Member

thanks so much, this is great.

@PrettyWood PrettyWood mentioned this pull request Jun 20, 2022
12 tasks
@dswij dswij deleted the frozenset branch June 21, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants