New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #452 - Adding support for populate_by_name #454

Merged

hramezani merged 2 commits into pydantic:main from hozn:populate-by-name

Oct 21, 2024

Contributor

hozn commented Oct 21, 2024

Adds support for populate_by_name model config and a handful of tests to validate this functionality.

I wasn't 100% sure on whether the preference was to modify existing tests (which, for example, ensure that populate-by-name is not happening), but I opted to create new tests for this code path specifically.
I only added tests for env and dotenv. Let me know if more coverage is needed on some of the alternative options.

hozn added 2 commits

October 21, 2024 14:38


          Fixes pydantic#452 - Adding support for populate_by_name and some tes…

91462ed

…ts to validate this works.


          Python 3.8 compat fix

0d05c49

hramezani approved these changes

View reviewed changes

Member

hramezani commented Oct 21, 2024

Thanks @hozn

hramezani merged commit 93d7b7b into pydantic:main

21 checks passed

hozn deleted the populate-by-name branch

October 22, 2024 12:48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet