Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): correct md link syntax in HISTORY.md #9530

Merged
merged 1 commit into from
May 30, 2024
Merged

fix(docs): correct md link syntax in HISTORY.md #9530

merged 1 commit into from
May 30, 2024

Conversation

nedbat
Copy link
Contributor

@nedbat nedbat commented May 30, 2024 •
edited by pydantic-hooky bot
Loading

Change Summary

Three links in HISTORY.md weren't correct Markdown syntax.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist: NA
  • Tests pass on CI
  • Documentation reflects the changes where applicable: NA
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Selected Reviewer: @davidhewitt

@github-actions github-actions bot added the relnotes-fix Used for bugfixes. label May 30, 2024
@nedbat
Copy link
Contributor Author

nedbat commented May 30, 2024

please review

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented May 30, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9530 will not alter performance

Comparing nedbat:patch-1 (04d7c03) with main (1f47473)

Summary

✅ 13 untouched benchmarks

sydney-runkle
sydney-runkle approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@sydney-runkle sydney-runkle enabled auto-merge (squash) May 30, 2024 17:05
@nedbat nedbat closed this May 30, 2024
auto-merge was automatically disabled May 30, 2024 17:06

Pull request was closed

@nedbat nedbat reopened this May 30, 2024
@sydney-runkle sydney-runkle merged commit e67524c into pydantic:main May 30, 2024
104 checks passed
@nedbat
Copy link
Contributor Author

nedbat commented May 30, 2024

@sydney-runkle btw, I hear "welcome to Boston" is in order :) https://about.bostonpython.com

@sydney-runkle
Copy link
Member

@nedbat, indeed, thanks! I'm excited to move this coming fall. I'll certainly be attending some Boston Python events :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees

@davidhewitt davidhewitt

Labels
ready for review relnotes-fix Used for bugfixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nedbat @sydney-runkle @davidhewitt