fix: deprecate pygments related variable to correct typos #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: change the html_theme options to match pygments name fix: rollback package deps Previous HEAD was c227736
|
Rebase (and squashed for soimplicity). |
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||
drammock
reviewed
May 21, 2024
drammock
approved these changes
May 21, 2024
|
Thanks for rebasing this @Carreau. Assuming I didn't break anything by editing through GH web UI, this can be merged when CIs are green. |
ivanov
pushed a commit
to ivanov/pydata-sphinx-theme
that referenced
this pull request
Jun 5, 2024
* refactor: rename variables fix: change the html_theme options to match pygments name fix: rollback package deps Previous HEAD was c227736 * Apply suggestions from code review --------- Co-authored-by: Daniel McCloy <dan@mccloy.info>
Carreau
pushed a commit
that referenced
this pull request
Jun 13, 2024
a couple bits that were missed in #1614
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1594
As mentioned in the issue, the code highlighting lib name is "pygments" and not "pygment". I tracked down all occurences of the word "pygment" without "S" and updated it. Deprecation cycle is due to v1.0.
changes:
pygments_light_style/pygments_dark_styleparameter